Make the package-json path repo-relative #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
repo-relative-release-plan-paths
branch
from
bbe12b7
to
889e098
Compare
…lease to be ran in other places than the root directory, just in case people do that
NullVoxPopuli
force-pushed
the
repo-relative-release-plan-paths
branch
from
889e098
to
33efc39
Compare
mansona
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks: #1492
Today, in the release-plan.json, the pkgJSONPath is the absolute path to each package.json on the machine that ran the command last.
To allow for anyone to generate and interpret a release-plan, we need to move to repo-relative paths.
All the tools that I saw that read the pkgJSONPath will respect the current working directory -- but that would mean that the
embroider-releasetool can only be ran from the repo root -- so whenever the relative path is read, I converted it to an absolute path.To test:
pnpm ipnpm compile --watch(or without watch)export GITHUB_AUTH=xyz(I used a classic token with repo permissions that I've since deleted)pnpm exec embroider-release explain-plan(to see what to expect in the .release-plan.json)pnpm exec embroider-release prepare(to generate / update the .release-plan.json)Diff should look something like this:
